-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge ert storage #6127
Closed
Closed
Merge ert storage #6127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Øystein Olai Heggen <[email protected]>
The code used to combine the chunks in upload order rather than block_index order. This commit fixes this issue.
- Add observationOut helper function - Refactor experiment/prioirs - Add helper function to Update endpoint - Make use of ensemble_ids - Change relative import to absolute - Fix priors into new_record_matrix
- Migrate prior endpoint tests into experiment - Add get single experiment endpoint
SQLAlchemy complains about cache_ok not existing in UUID and spamming me with warnings. We tell it that UUID is cacheable and that it's all fine.
The `Metadata` field that points to the `_metadata` column in SQL used to be auto-generated by the Graphene-SQLAlchemy package. Now there's only the `userdata` field. Further, this commit removes the `metadata_dict` property in favour of having the column default to `{}`.
Modify testclient post, get, .. to comply with requests types
This reverts commit aaccf35.
This reverts commit 2995218.
This reverts commit 21c64d2.
This reverts commit 0bae073.
This reverts commit 9e86992.
These replace client.Session with versions that: 1. Cache a global connection information 2. Accept a `ConnInfo` object so that we don't have to create files or set environment variables. 3. Look for `storage_server.json` in any parent directory
fastapi had breaking change in 0.74.0 where we now need to specifically handle only exceptions related to our database transaction. https://fastapi.tiangolo.com/release-notes/#breaking-changes
Endpoint gives info about server, for now only a name.
pinkwah
force-pushed
the
merge-ert-storage
branch
3 times, most recently
from
September 22, 2023 11:28
f50ede4
to
aff25dc
Compare
Codecov Report
@@ Coverage Diff @@
## main #6127 +/- ##
==========================================
+ Coverage 82.42% 82.54% +0.12%
==========================================
Files 350 361 +11
Lines 21457 21626 +169
Branches 839 839
==========================================
+ Hits 17685 17851 +166
- Misses 3474 3477 +3
Partials 298 298
... and 22 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pinkwah
force-pushed
the
merge-ert-storage
branch
2 times, most recently
from
September 22, 2023 12:26
4eca6ab
to
fd18c4a
Compare
This drops the requirement of having an external provider of the ERT Storage API. One day we may resurrect ert-storage as an entirely separate service, but as of today only dark_storage should be supported.
pinkwah
force-pushed
the
merge-ert-storage
branch
from
September 22, 2023 12:49
fd18c4a
to
e4e16da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.