Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ert storage #6127

Closed
wants to merge 44 commits into from
Closed

Merge ert storage #6127

wants to merge 44 commits into from

Conversation

pinkwah
Copy link
Contributor

@pinkwah pinkwah commented Sep 20, 2023

No description provided.

pinkwah and others added 30 commits May 31, 2021 15:20
The code used to combine the chunks in upload order rather than
block_index order. This commit fixes this issue.
- Add observationOut helper function
- Refactor experiment/prioirs
- Add helper function to Update endpoint
- Make use of ensemble_ids
- Change relative import to absolute
- Fix priors into new_record_matrix
- Migrate prior endpoint tests into experiment
- Add get single experiment endpoint
SQLAlchemy complains about cache_ok not existing in UUID and spamming me
with warnings. We tell it that UUID is cacheable and that it's all fine.
The `Metadata` field that points to the `_metadata` column in SQL used
to be auto-generated by the Graphene-SQLAlchemy package. Now there's
only the `userdata` field. Further, this commit removes the
`metadata_dict` property in favour of having the column default to `{}`.
Modify testclient post, get, .. to comply with requests types
This reverts commit 2995218.
These replace client.Session with versions that:
1. Cache a global connection information
2. Accept a `ConnInfo` object so that we don't have to create files or
   set environment variables.
3. Look for `storage_server.json` in any parent directory
@pinkwah pinkwah force-pushed the merge-ert-storage branch 3 times, most recently from f50ede4 to aff25dc Compare September 22, 2023 11:28
@codecov-commenter
Copy link

Codecov Report

Merging #6127 (aff25dc) into main (8a15332) will increase coverage by 0.12%.
Report is 5 commits behind head on main.
The diff coverage is 93.44%.

@@            Coverage Diff             @@
##             main    #6127      +/-   ##
==========================================
+ Coverage   82.42%   82.54%   +0.12%     
==========================================
  Files         350      361      +11     
  Lines       21457    21626     +169     
  Branches      839      839              
==========================================
+ Hits        17685    17851     +166     
- Misses       3474     3477       +3     
  Partials      298      298              
Files Changed Coverage Δ
src/ert/dark_storage/security.py 60.00% <60.00%> (ø)
src/ert/dark_storage/app.py 82.85% <81.25%> (+0.50%) ⬆️
src/ert/dark_storage/json_schema/ensemble.py 87.50% <87.50%> (ø)
src/ert/dark_storage/exceptions.py 92.85% <92.85%> (ø)
src/ert/dark_storage/compute/misfits.py 93.75% <93.75%> (ø)
src/ert/dark_storage/json_schema/prior.py 98.24% <98.24%> (ø)
src/ert/dark_storage/compute/__init__.py 100.00% <100.00%> (ø)
src/ert/dark_storage/endpoints/compute/misfits.py 83.72% <100.00%> (ø)
src/ert/dark_storage/endpoints/ensembles.py 85.18% <100.00%> (ø)
src/ert/dark_storage/endpoints/experiments.py 81.08% <100.00%> (ø)
... and 10 more

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pinkwah pinkwah force-pushed the merge-ert-storage branch 2 times, most recently from 4eca6ab to fd18c4a Compare September 22, 2023 12:26
This drops the requirement of having an external provider of the ERT
Storage API. One day we may resurrect ert-storage as an entirely
separate service, but as of today only dark_storage should be supported.
@pinkwah pinkwah closed this Dec 14, 2023
@pinkwah pinkwah deleted the merge-ert-storage branch December 14, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.